OpenWriterControle/dev/docs/context-reference-convention.md
Darren Hinde c8f7103cb6
refactor(evals): consolidate documentation and enhance test infrastructure (#56)
* feat(agents): implement category-based agent organization system

- Organize agents into domain categories (core, development, content, data, product, learning)
- Move 10 agents to category subdirectories with proper git rename tracking
- Update 13 subagents with category and type metadata in frontmatter
- Add category metadata files (0-category.json) documenting common patterns
- Implement local registry fallback in install script for offline development
- Add comprehensive validation suite with 15 automated tests (100% pass rate)
- Enhance registry validation with duplicate ID and consistency checks
- Update eval framework with intelligent path resolution (backward compatible)
- Archive legacy eval structure to _archive/ for reference
- Update all documentation to reflect category-based structure
- Bump version to 0.5.0 with accurate CHANGELOG

Technical Details:
- 23 agents organized (10 category agents, 13 subagents)
- 6 category directories created
- Path resolution supports both agent IDs and category paths
- Registry schema updated to v2.0.0
- 159 files changed, 872 insertions(+), 10738 deletions(-)

BREAKING CHANGE: Agent file paths now use category structure. Update references from .opencode/agent/openagent.md to .opencode/agent/core/openagent.md. Eval framework maintains backward compatibility via path resolution.

* refactor(evals): consolidate documentation and enhance test infrastructure

- Remove temporary project tracking files (PHASE_5_COMPLETE, PROJECT_COMPLETE, etc.)
- Consolidate evaluation framework docs into main README
- Enhance test execution with improved logging and multi-prompt support
- Move system-builder from core to meta category
- Add comprehensive test suites for openagent with organized structure
- Create evaluation test structure for all subagents
- Clean up archived workflows and redundant documentation
- Update registry to reflect new agent organization
- Add shared test templates and golden test patterns

* feat(ci): add manual trigger support for bot-created PRs in validate-registry workflow

- Add pr_number input to workflow_dispatch for manually triggering validation
- Fetch PR details dynamically when triggered manually
- Support both automatic (PR event) and manual (workflow_dispatch) triggers
- Enable validation of bot-created PRs like automated version bumps
- Update branch detection and push logic to handle both trigger types
- Add documentation explaining how to manually trigger for bot PRs

* feat(evals): add explicit context file validation to test framework

- Add expectedContextFiles field to test YAML schema for explicit context file specification
- Enhance context-loading-evaluator to support both auto-detect and explicit validation modes
- Update documentation with comprehensive guide and examples
- Clean up archived legacy test structure (90+ old test files)
- Add new example tests demonstrating explicit context validation
- Backward compatible with existing tests

* feat(evals): add multi-agent logging system and performance optimizations

Implement comprehensive multi-agent logging and performance improvements for the eval framework.

Task 01: Multi-Agent Logging System
- Add complete hierarchical logging module (evals/framework/src/logging/)
  - SessionTracker: tracks parent-child delegation hierarchies
  - MultiAgentLogger: pretty-prints logs with visual indentation
  - Formatters: box characters and emoji formatting
  - 37 passing unit tests (session-tracker, logger, integration)
- Integrate with SDK event stream handler
  - Hook into session.created, message.updated, message.part.updated events
  - Real-time child session detection via timestamp heuristics
  - Message deduplication for cleaner output
- Enable in debug mode only (<1% performance overhead)
- Add demo script and comprehensive documentation

Task 02: Performance Optimizations
- Reduce grace period from 5s to 2s (67% reduction, 10-20% faster tests)
- Add PerformanceMetricsEvaluator for bottleneck identification
  - Collects tool latencies, inference time, idle time
  - Provides full performance visibility
- Update smoke test to validate delegation (core feature)
  - Replace simple read test with multi-agent delegation test
  - Tests both parent and child agent functionality
  - Validates multi-agent logging system

Results:
- 37 unit tests passing
- Smoke test passing (95/100 score)
- Clean hierarchical logging output
- 10-20% faster test execution
- Full multi-agent visibility

Files changed: 16 files, +2678 lines
Time saved: ~6-8 days (completed in 6 hours vs 3-5 day estimate)

* feat(evals): show child agent execution in non-debug mode

- Enable MultiAgentLogger in both debug and non-debug modes
- Add verbose parameter to control output level
- Non-verbose mode shows concise child session lifecycle:
  - Child agent started message
  - Child agent completed with duration
- Verbose mode (--debug) shows full delegation hierarchy
- Update documentation to reflect new behavior

This provides visibility into delegation without overwhelming output,
giving confidence that child agents are actually running.

* feat(evals): improve delegation testing and behavior validation

Major improvements to eval framework:

Test Suite:
- Add 00-smoke-test.yaml (basic read operation)
- Rename 01-smoke-test.yaml → 02-delegation-test.yaml (delegation test)
- Add simple-responder test agent for delegation testing
- Add debug test: simple-subagent-call.yaml

Evaluators:
- Add agent-model-evaluator.ts for agent/model validation
- Enhance behavior-evaluator.ts with detailed task tool output
- Improve delegation-evaluator.ts with better evidence tracking

Schema & Execution:
- Add expectedAgent and expectedModel to test schema
- Improve test executor with better logging and error handling

Documentation:
- Update evals/README.md with new features and performance improvements
- Remove outdated MULTI_AGENT_LOGGING_COMPLETE.md

Registry:
- Add simple-responder test agent to registry

Fixes:
- Fix dashboard.sh path resolution

These changes provide better visibility into delegation, improved test
coverage, and clearer validation of agent behavior.

* chore: add GitHub Actions workflow and plugin documentation

- Add .github/workflows/evals/run-evaluations.yml for automated eval testing
- Add dev/ai-tools/opencode/plugins/Plugin-inspiration.md for plugin development reference
2025-12-18 09:52:11 +00:00

364 lines
8 KiB
Markdown

# Context Reference Convention
## Overview
All context file references in OpenAgents **MUST** use the standardized format:
```markdown
@.opencode/context/path/to/file.md
```
This convention is **required** for the installation system to work correctly across local and global installations.
---
## The Requirement
### ✅ Correct Format
```markdown
@.opencode/context/core/essential-patterns.md
@.opencode/context/project/project-context.md
@.opencode/context/security/auth.md
```
### ❌ Incorrect Formats
```markdown
@context/core/patterns.md ❌ Missing .opencode prefix
@~/context/file.md ❌ Absolute path (breaks local installs)
@$CONTEXT_DIR/file.md ❌ Variables (can't be transformed)
../context/file.md ❌ Relative path (unreliable)
```
---
## Why This Convention?
### Problem: Local vs Global Installations
Users can install OpenAgents in two ways:
**Local Install:**
```bash
.opencode/
├── agent/
├── command/
└── context/
```
References work as: `@.opencode/context/file.md` (relative to current directory)
**Global Install:**
```bash
~/.config/opencode/
├── agent/
├── command/
└── context/
```
References need to be: `@~/.config/opencode/context/file.md` (absolute path)
### Solution: Install-Time Transformation
The installation script automatically transforms references based on installation type:
```bash
# Local install (.opencode/)
@.opencode/context/test.md → @.opencode/context/test.md (no change)
# Global install (~/.config/opencode/)
@.opencode/context/test.md → @~/.config/opencode/context/test.md (transformed)
# Custom install (/usr/local/opencode/)
@.opencode/context/test.md → @/usr/local/opencode/context/test.md (transformed)
```
---
## How It Works
### Repository Files (Source)
All files in the repository use the standard format:
```markdown
# Example Agent
Load patterns from @.opencode/context/core/essential-patterns.md
```
### Installation Process
When a user installs globally, the installer:
1. Downloads the file
2. Detects global installation (INSTALL_DIR != ".opencode")
3. Transforms all references:
```bash
sed -e "s|@\.opencode/context/|@${INSTALL_DIR}/context/|g" \
-e "s|\.opencode/context|${INSTALL_DIR}/context|g" file.md
```
4. Saves the transformed file
### Result
**After global install to ~/.config/opencode:**
```markdown
# Example Agent
Load patterns from @/Users/username/.config/opencode/context/core/essential-patterns.md
```
---
## What Gets Transformed
### All File Types
The transformation applies to **EVERY** file during installation:
- ✅ Agent files (`.opencode/agent/*.md`)
- ✅ Subagent files (`.opencode/agent/subagents/*.md`)
- ✅ Command files (`.opencode/command/*.md`)
- ✅ Context files (`.opencode/context/**/*.md`)
- ✅ Any other markdown files
### All Reference Types
Both patterns are transformed:
**Pattern 1: @ References (OpenCode syntax)**
```markdown
@.opencode/context/file.md → @/install/path/context/file.md
```
**Pattern 2: Shell Commands**
```markdown
.opencode/context/file.md → /install/path/context/file.md
```
---
## Testing & Validation
### Why We Enforce This
During development and testing, we discovered:
1. **Inconsistent references broke installations** - Some files used `@context/`, others used `@.opencode/context/`
2. **Variable-based paths couldn't be transformed** - `@$CONTEXT_DIR/file.md` can't be reliably replaced
3. **Relative paths were unreliable** - `../context/file.md` broke when files moved
4. **Absolute paths broke local installs** - `@~/.config/opencode/context/` doesn't work for `.opencode/`
### Test Results
With the standardized convention:
- ✅ 31/31 tests passed (100% success rate)
- ✅ Works for local installations
- ✅ Works for global installations
- ✅ Works for custom installation paths
- ✅ Transforms all file types correctly
- ✅ Handles multiple references per file
---
## Implementation Details
### Detection Logic
The installer determines if transformation is needed:
```bash
if [[ "$INSTALL_DIR" != ".opencode" ]] && [[ "$INSTALL_DIR" != *"/.opencode" ]]; then
# Global install detected → Transform paths
else
# Local install detected → Keep original paths
fi
```
### Transformation Command
```bash
sed -i.bak -e "s|@\.opencode/context/|@${expanded_path}/context/|g" \
-e "s|\.opencode/context|${expanded_path}/context|g" "$dest"
rm -f "${dest}.bak"
```
**Explanation:**
- `-i.bak` - Edit in-place, create backup
- First pattern - Transform @ references
- Second pattern - Transform shell command paths
- `g` flag - Replace ALL occurrences
- Remove backup file after transformation
---
## Developer Guidelines
### When Creating New Files
**Always use the standard format:**
```markdown
# Good Examples ✅
@.opencode/context/core/essential-patterns.md
@.opencode/context/project/project-context.md
@.opencode/context/security/auth.md
# Bad Examples ❌
@context/file.md
@~/context/file.md
@$CONTEXT_DIR/file.md
../context/file.md
```
### When Referencing Context
**In agents:**
```markdown
Load context from @.opencode/context/core/essential-patterns.md
```
**In commands:**
```markdown
Reference: @.opencode/context/project/project-context.md
```
**In context files:**
```markdown
See also: @.opencode/context/security/auth.md
```
**In shell commands:**
```markdown
!`ls .opencode/context/`
!`find .opencode/context -name "*.md"`
```
---
## Validation
### Pre-Commit Validation
The repository includes a validation script:
```bash
./scripts/validation/validate-context-refs.sh
```
This checks all markdown files for:
- ✅ Correct `@.opencode/context/` format
- ❌ Forbidden dynamic variables (`@$VAR/`)
- ❌ Non-standard references
### Manual Validation
Check a file manually:
```bash
# Should only find @.opencode/context/ references
grep -E '@[^~$]' file.md | grep -v '@.opencode/context/'
# Should return nothing (empty result = good)
```
---
## Examples
### Example 1: Agent File
**File:** `.opencode/agent/core/openagent.md`
```markdown
# OpenAgent
<context>
Load essential patterns from @.opencode/context/core/essential-patterns.md
Load project context from @.opencode/context/project/project-context.md
</context>
## Workflow
1. Analyze request
2. Check patterns in @.opencode/context/core/essential-patterns.md
3. Execute task
```
**After global install to ~/.config/opencode:**
```markdown
# OpenAgent
<context>
Load essential patterns from @/Users/username/.config/opencode/context/core/essential-patterns.md
Load project context from @/Users/username/.config/opencode/context/project/project-context.md
</context>
## Workflow
1. Analyze request
2. Check patterns in @/Users/username/.config/opencode/context/core/essential-patterns.md
3. Execute task
```
---
### Example 2: Command File
**File:** `.opencode/command/commit.md`
```markdown
# Commit Command
Reference patterns from @.opencode/context/core/essential-patterns.md
Check .opencode/context/project/project-context.md for commit conventions.
```
**After global install to /usr/local/opencode:**
```markdown
# Commit Command
Reference patterns from @/usr/local/opencode/context/core/essential-patterns.md
Check /usr/local/opencode/context/project/project-context.md for commit conventions.
```
---
## Summary
### The Rule
**All context references MUST use:**
```markdown
@.opencode/context/path/to/file.md
```
### Why
- ✅ Works for local installations
- ✅ Works for global installations
- ✅ Works for custom installation paths
- ✅ Automatically transformed during installation
- ✅ Tested and validated
- ✅ Consistent across all files
### Enforcement
- Pre-commit validation script
- Installation system validation
- Code review guidelines
- This documentation
---
## Related Documentation
- [Installation Flow Analysis](../../INSTALLATION_FLOW_ANALYSIS.md)
- [Test Report](../../TEST_REPORT.md)
- [Final Review](../../FINAL_REVIEW.md)
---
**Last Updated:** 2024-11-19
**Status:** Required Convention
**Validation:** Automated via `scripts/validation/validate-context-refs.sh`