cclohmar/vm-bench
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: corrupted event listeners and undefined sessionId from overzealous string replace

Browse source 
The Python replacement script changed ALL 'error' strings to
'pve-alert pve-alert-error', including:
- addEventListener('error', ...) → broken event listener
- data.phase === 'error' → never matched
- sessionId variable definition was lost/doubled

Restored proper event names and phase comparisons.
This commit is contained in:
Claus Lohmar 2026-07-23 10:56:50 +00:00
parent 6db69f434c
commit 39cf91cbc4
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frontend/templates/index.html
View file

@ -146,6 +146,7 @@ async function handleUpload(formData) {
const file = formData.get('source_file');
const vmid = formData.get('vmid');
const vmName = formData.get('vm_name');
const sessionId = formData.get('session_id') || '';
// Raw streaming upload — bypasses multipart parsing
xhr.open('POST', '/session/upload-raw');
@ -154,7 +155,6 @@ async function handleUpload(formData) {
xhr.setRequestHeader('X-VMID', vmid);
xhr.setRequestHeader('X-VM-Name', vmName);
xhr.setRequestHeader('X-Session-ID', sessionId);
xhr.setRequestHeader('X-Session-ID', sessionId);
xhr.upload.addEventListener('progress', (e) => {
if (e.lengthComputable) {
@ -186,7 +186,7 @@ async function handleUpload(formData) {
}
resolve();
});
xhr.addEventListener('pve-alert pve-alert-error', () => { setPhase('Upload failed', 0, false); showError('Network error.'); resolve(); });
xhr.addEventListener('error', () => { setPhase('Upload failed', 0, false); showError('Network error.'); resolve(); });
xhr.send(file); // raw binary — no multipart overhead
});
}
@ -197,7 +197,7 @@ async function handleDownload(formData) {
try { resp = await fetch('/session/upload', { method: 'POST', body: formData }); }
catch (err) { setPhase('Download failed', 0, false); showError('Network error: ' + err.message); return; }
const data = await resp.json();
if (data.phase === 'pve-alert pve-alert-error') { setPhase('Download failed', 0, false); showError(data.error); return; }
if (data.phase === 'error') { setPhase('Download failed', 0, false); showError(data.error); return; }
if (data.phase !== 'downloading') { setPhase('Unexpected: ' + data.phase, 0, false); return; }
const filename = data.filename;
@ -211,7 +211,7 @@ async function handleDownload(formData) {
setPhase('Download complete (' + (pdata.file_size_gb || 0) + ' GiB)', 100, false);
await sleep(500); await runAnalysis(data.vmid, filename, data.vm_name); return;
}
if (pdata.phase === 'pve-alert pve-alert-error') { setPhase('Download failed', 0, false); showError(pdata.error); return; }
if (pdata.phase === 'error') { setPhase('Download failed', 0, false); showError(pdata.error); return; }
if (pdata.phase === 'too_slow') {
setPhase('Download too slow', 0, false);
showError('<strong>Download cancelled — too slow.</strong><br><br>' + (pdata.message || '') +