From df81309281be2cd36db81252b657613135a08dd9 Mon Sep 17 00:00:00 2001 From: root Date: Thu, 16 Jul 2026 14:26:27 +0000 Subject: [PATCH] chore: remove Card Types, merge into Team --- AGENTS.md | 2 +- .../engagement_card/engagement_card.json | 12 +------ .../service_factory_settings.json | 14 -------- .../service_factory_settings.py | 6 ---- .../doctype/sf_settings_card_type/__init__.py | 0 .../sf_settings_card_type.json | 32 ------------------- .../sf_settings_card_type.py | 4 --- 7 files changed, 2 insertions(+), 68 deletions(-) delete mode 100644 service_factory/service_factory/service_factory/doctype/sf_settings_card_type/__init__.py delete mode 100644 service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.json delete mode 100644 service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.py diff --git a/AGENTS.md b/AGENTS.md index 359af8f..1741139 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,6 +1,6 @@ # Service Factory — ERPNext Custom App Project -> **Current Version: V0.1.0015** — Each completed prompt/step increments the patch number by 1 (V0.1.0000 → V0.1.0001 → V0.1.0002…). The agent automatically commits and pushes after every step. +> **Current Version: V0.1.0016** — Each completed prompt/step increments the patch number by 1 (V0.1.0000 → V0.1.0001 → V0.1.0002…). The agent automatically commits and pushes after every step. ## Project Overview diff --git a/service_factory/service_factory/service_factory/doctype/engagement_card/engagement_card.json b/service_factory/service_factory/service_factory/doctype/engagement_card/engagement_card.json index 6343629..dfd9cc4 100644 --- a/service_factory/service_factory/service_factory/doctype/engagement_card/engagement_card.json +++ b/service_factory/service_factory/service_factory/doctype/engagement_card/engagement_card.json @@ -13,8 +13,7 @@ "engine": "InnoDB", "field_order": [ "naming_series", - "card_type", - "status", + "status", "task", "title", "column_break_1", @@ -56,15 +55,6 @@ "reqd": 1, "set_only_once": 1 }, - { - "fieldname": "card_type", - "fieldtype": "Select", - "in_list_view": 1, - "in_standard_filter": 1, - "label": "Card Type", - "options": "service_factory.service_factory.doctype.service_factory_settings.service_factory_settings.get_card_type_options", - "reqd": 1 - }, { "fieldname": "task", "fieldtype": "Select", diff --git a/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.json b/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.json index d964a8a..f11c61b 100644 --- a/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.json +++ b/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.json @@ -8,26 +8,12 @@ "editable_grid": 1, "engine": "InnoDB", "field_order": [ - "section_card_types", - "card_types", "section_task_types", "task_types", "section_teams", "teams" ], "fields": [ - { - "fieldname": "section_card_types", - "fieldtype": "Section Break", - "label": "Engagement Card Types" - }, - { - "fieldname": "card_types", - "fieldtype": "Table", - "label": "Card Types", - "options": "SF Settings Card Type", - "reqd": 0 - }, { "fieldname": "section_task_types", "fieldtype": "Section Break", diff --git a/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.py b/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.py index 72d3e4a..5a4c481 100644 --- a/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.py +++ b/service_factory/service_factory/service_factory/doctype/service_factory_settings/service_factory_settings.py @@ -6,12 +6,6 @@ class ServiceFactorySettings(Document): pass -def get_card_type_options(doc=None, fieldname=None): - """Return card type names from Settings for dynamic Select field.""" - settings = frappe.get_single("Service Factory Settings") - return [row.card_type_name for row in settings.card_types] - - def get_task_type_options(doc=None, fieldname=None): """Return task type names from Settings for dynamic Select field.""" settings = frappe.get_single("Service Factory Settings") diff --git a/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/__init__.py b/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/__init__.py deleted file mode 100644 index e69de29..0000000 diff --git a/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.json b/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.json deleted file mode 100644 index 9911650..0000000 --- a/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.json +++ /dev/null @@ -1,32 +0,0 @@ -{ - "actions": [], - "allow_rename": 0, - "autoname": "hash", - "creation": "2026-07-16 12:00:00.000000", - "doctype": "DocType", - "editable_grid": 1, - "engine": "InnoDB", - "field_order": ["card_type_name"], - "fields": [ - { - "fieldname": "card_type_name", - "fieldtype": "Data", - "in_list_view": 1, - "label": "Card Type", - "reqd": 1 - } - ], - "istable": 1, - "links": [], - "modified": "2026-07-16 12:00:00.000000", - "modified_by": "Administrator", - "module": "Service Factory", - "name": "SF Settings Card Type", - "naming_rule": "Random", - "owner": "Administrator", - "permissions": [], - "sort_field": "modified", - "sort_order": "DESC", - "states": [], - "track_changes": 0 -} diff --git a/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.py b/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.py deleted file mode 100644 index f869f29..0000000 --- a/service_factory/service_factory/service_factory/doctype/sf_settings_card_type/sf_settings_card_type.py +++ /dev/null @@ -1,4 +0,0 @@ -from frappe.model.document import Document - -class SFSettingsCardType(Document): - pass