OpenWriterControle/scripts/tests/test-compatibility.sh
Darren Hinde 013682c499
fix: resolve installer failures and add comprehensive validation (#189)
* fix: ContextScout falls back to global core/ when local core/ missing

Users who install OAC globally have core standards at
~/.config/opencode/context/core/ but no local core/ directory.
ContextScout now does a one-time check on startup: if local
core/navigation.md doesn't exist, it checks the global path
from paths.json. This resolves the ENOENT errors when agents
try to read core/standards/ files that only exist globally.

- paths.json: enabled global path (~/.config/opencode/context)
- contextscout.md: added global_fallback rule with 2-glob cap
- Fallback is ONLY for core/ files, never project-intelligence

* docs: add context resolution explanation to README

Explains how ContextScout resolves context files: local-first,
global fallback only for core/ files, project-intelligence always
local. Includes flow diagram, key rules, and common setup table.

* fix: resolve installer failures and add comprehensive validation

## Summary
Fixes critical installer failures where ContextScout and other components couldn't find their configuration files after installation. Adds comprehensive validation system to prevent future issues.

## Problems Fixed

### 1. Missing Critical Files (13 dead registry references)
Files were referenced in registry but didn't exist on disk:
- workflows-delegation (split into 3 files)
- design-iteration (split into 8 files)
- animation-patterns (split into 6 files)
- adding-agent (split into 2 files)
- adding-skill (split into 3 files)
- navigation-design (split into 2 files)
- external-libraries (split into 3 files)
- claude-code-docs/* (directory removed)

### 2. Missing Infrastructure Files
ContextScout failed after installation because 2 critical files weren't in registry:
- paths.json - Context root configuration
- navigation.md - Root navigation for discovery

### 3. Profile Inconsistencies
Profiles referenced components that don't exist:
- context:adding-skill → context:adding-skill-basics
- context:animation-patterns → animation-basics/components/advanced
- context:design-assets (removed - doesn't exist)
- context:to-be-consumed/* (removed - directory doesn't exist)
- skill:context-manager → subagent:context-manager

## Changes Made

### Registry (registry.json)
- Removed 13 dead references
- Added 27 new split-file entries
- Added 2 critical infrastructure entries
- Fixed all 5 profile configurations
- Updated ContextScout dependencies
- Updated agent-metadata.json dependencies

### New Validation Scripts
- scripts/registry/check-dependencies.ts - Comprehensive dependency checker
- scripts/tests/test-installer-files.sh - Installer simulation test
- scripts/registry/fix-registry.py - Automated registry fixer
- scripts/hooks/pre-commit - Git pre-commit hook

### Documentation
- docs/maintenance/REGISTRY_FIXES_SUMMARY.md
- docs/maintenance/CONTEXTSCOUT_FIX.md
- docs/maintenance/REGISTRY_VALIDATION.md

## Validation Results

Before:
- 13 missing files in registry
- 78 orphaned files on disk
- 3 missing dependencies
- Installer would fail

After:
- 244 total paths, 0 missing
- 262 dependency checks, 0 failures
- 0 orphaned dependencies
- All profiles consistent
- Installer works correctly

## Testing

```bash
# Registry validation
bun run scripts/registry/validate-registry.ts
# ✓ All 244 paths valid

# Dependency checking
bun run scripts/registry/check-dependencies.ts
# ✓ All 262 checks passed

# Installer test
./scripts/tests/test-installer-files.sh --local --profile=essential
# ✓ All files accessible
```

## Usage

### Run validation before commits:
```bash
bun run scripts/registry/check-dependencies.ts
```

### Install pre-commit hook:
```bash
cp scripts/hooks/pre-commit .git/hooks/pre-commit
chmod +x .git/hooks/pre-commit
```

### Test installer:
```bash
./scripts/tests/test-installer-files.sh --local --profile=essential
```

## Impact

This fix ensures:
- ✓ Installer downloads all required files
- ✓ ContextScout works immediately after install
- ✓ No broken dependencies
- ✓ No missing profile components
- ✓ Future issues caught by validation

## Breaking Changes

None - all changes are additive or fix broken references.

## Related

- Fixes: ContextScout failing after installation
- Prevents: Missing file errors during install
- Adds: Comprehensive validation system

* fix: resolve shellcheck warnings in test scripts

- Remove unused REPO_URL variable from test-installer-files.sh
- Add shellcheck disable comments for cleanup functions used via trap
- Fixes CI failures in ShellCheck Analysis workflow

* fix: resolve shellcheck errors across all scripts

Fixed arithmetic expansion issues and code quality warnings:
- Changed ((var++)) to POSIX-compliant 1 syntax
- Fixed unquoted variables and grep pipe issues (SC2002, SC2143)
- Added shellcheck disable comments for intentional patterns
- Fixed variable initialization and return statement placement

Scripts fixed:
- scripts/tests/*.sh (5 files)
- scripts/registry/*.sh (4 files)
- scripts/validation/*.sh (2 files)
- scripts/*.sh (2 files)
- evals/framework/scripts/*.sh (2 files)

All scripts now pass shellcheck --severity=warning

* chore: trigger CI shellcheck validation
2026-02-06 17:07:42 +00:00

181 lines
5.1 KiB
Bash
Executable file

#!/usr/bin/env bash
#############################################################################
# Compatibility Test Script
# Tests the installer across different bash versions and platforms
#############################################################################
set -e
echo "╔════════════════════════════════════════════════════════════════╗"
echo "║ OpenCode Installer Compatibility Test ║"
echo "╚════════════════════════════════════════════════════════════════╝"
echo ""
# Colors
GREEN='\033[0;32m'
RED='\033[0;31m'
YELLOW='\033[1;33m'
NC='\033[0m'
pass() {
echo -e "${GREEN}✓${NC} $1"
}
fail() {
echo -e "${RED}✗${NC} $1"
exit 1
}
warn() {
echo -e "${YELLOW}⚠${NC} $1"
}
echo "System Information:"
echo " Platform: $(uname -s)"
echo " Bash Version: $BASH_VERSION"
echo " Shell: $SHELL"
echo ""
# Test 1: Bash version check
echo "Test 1: Bash Version Compatibility"
bash_major="${BASH_VERSION%%.*}"
if [ "$bash_major" -ge 3 ]; then
pass "Bash version $BASH_VERSION is compatible (3.2+ required)"
else
fail "Bash version $BASH_VERSION is too old (3.2+ required)"
fi
# Test 2: Required commands
echo ""
echo "Test 2: Required Dependencies"
for cmd in curl jq; do
if command -v "$cmd" &> /dev/null; then
pass "$cmd is installed"
else
fail "$cmd is not installed"
fi
done
# Test 3: Script syntax check
echo ""
echo "Test 3: Script Syntax Check"
if bash -n install.sh 2>/dev/null; then
pass "Script syntax is valid"
else
fail "Script has syntax errors"
fi
# Test 4: Help command
echo ""
echo "Test 4: Help Command"
if bash install.sh help 2>&1 | grep -q "Usage:"; then
pass "Help command works"
else
fail "Help command failed"
fi
# Test 5: List command
echo ""
echo "Test 5: List Command"
if bash install.sh list 2>&1 | grep -q "Available Components"; then
pass "List command works"
else
fail "List command failed"
fi
# Test 6: Profile argument parsing
echo ""
echo "Test 6: Profile Argument Parsing"
for profile in essential developer full advanced; do
# shellcheck disable=SC2216
if echo "n" | bash install.sh "$profile" 2>&1 | grep -q "Profile:"; then
pass "Profile '$profile' argument works"
else
fail "Profile '$profile' argument failed"
fi
done
# Test 7: Profile with dashes
echo ""
echo "Test 7: Profile Arguments with Dashes"
for profile in --essential --developer --full --advanced; do
# shellcheck disable=SC2216
if echo "n" | bash install.sh "$profile" 2>&1 | grep -q "Profile:"; then
pass "Profile '$profile' argument works"
else
fail "Profile '$profile' argument failed"
fi
done
# Test 8: Array operations
echo ""
echo "Test 8: Array Operations"
test_array=()
test_array+=("item1")
test_array+=("item2")
if [ ${#test_array[@]} -eq 2 ]; then
pass "Array operations work"
else
fail "Array operations failed"
fi
# Test 9: Parameter expansion
echo ""
echo "Test 9: Parameter Expansion"
test_string="type:id"
type="${test_string%%:*}"
id="${test_string##*:}"
if [ "$type" = "type" ] && [ "$id" = "id" ]; then
pass "Parameter expansion works"
else
fail "Parameter expansion failed"
fi
# Test 10: Temp directory creation
echo ""
echo "Test 10: Temp Directory Operations"
test_temp="/tmp/opencode-test-$$"
mkdir -p "$test_temp"
if [ -d "$test_temp" ]; then
pass "Temp directory creation works"
rm -rf "$test_temp"
else
fail "Temp directory creation failed"
fi
# Test 11: File operations
echo ""
echo "Test 11: File Operations"
test_file="/tmp/opencode-test-$$.txt"
echo "test" > "$test_file"
if [ -f "$test_file" ]; then
content=$(cat "$test_file")
if [ "$content" = "test" ]; then
pass "File operations work"
rm -f "$test_file"
else
fail "File read failed"
fi
else
fail "File write failed"
fi
# Test 12: Network connectivity
echo ""
echo "Test 12: Network Connectivity"
if curl -fsSL --max-time 5 https://raw.githubusercontent.com/darrenhinde/OpenAgentsControl/main/README.md > /dev/null 2>&1; then
pass "Network connectivity to GitHub works"
else
warn "Network connectivity test failed (may be offline)"
fi
echo ""
echo "╔════════════════════════════════════════════════════════════════╗"
echo "║ All Tests Passed! ✓ ║"
echo "╚════════════════════════════════════════════════════════════════╝"
echo ""
echo "Your system is compatible with the OpenCode installer."
echo "You can safely run:"
echo " curl -fsSL https://raw.githubusercontent.com/darrenhinde/OpenAgentsControl/main/install.sh | bash"
echo ""