fix: make admin bypass work properly for bot PRs (#113)
* fix: Add working admin bypass for validation workflow - Implement skip_validation flag that actually works - Admin can now bypass validation with: gh workflow run "Validate Registry on PR" -f pr_number=106 -f skip_validation=true - Workflow exits successfully when bypassed - Unblocks stuck bot PRs immediately * fix: make admin bypass work properly for bot PRs Problem: - Bot PRs don't auto-trigger workflows (GitHub security) - Repository ruleset requires 'validate-and-update' check to pass - Admin bypass exited job early, never reporting status to PR - Result: Bot PRs stuck, can't merge Solution: - Remove early 'exit 0' from admin bypass step - Add skip_validation condition to all validation steps - Job now completes successfully when bypassed - GitHub registers check as PASSED - PR can be merged Changes: - Updated workflow documentation with clear bypass instructions - Added skip conditions to 11 validation steps - Bypass now completes job instead of exiting early Usage: Actions → Validate Registry on PR → Run workflow - Enter PR number - Check 'skip_validation' for trusted bot PRs - Check passes immediately, PR can merge
This commit is contained in:
parent
254c8bf6db
commit
ac740fff06
1 changed files with 22 additions and 6 deletions
28
.github/workflows/validate-registry.yml
vendored
28
.github/workflows/validate-registry.yml
vendored
|
|
@ -5,11 +5,18 @@ name: Validate Registry on PR
|
|||
# For bot-created PRs (like automated version bumps), the workflow won't trigger automatically
|
||||
# due to GitHub's security restrictions. In those cases, you can manually trigger this workflow:
|
||||
#
|
||||
# Option 1 - Run Validation:
|
||||
# 1. Go to Actions > Validate Registry on PR > Run workflow
|
||||
# 2. Enter the PR number (e.g., 57)
|
||||
# 3. Click "Run workflow"
|
||||
# 2. Enter the PR number (e.g., 106)
|
||||
# 3. Leave "skip_validation" unchecked
|
||||
# 4. Click "Run workflow"
|
||||
#
|
||||
# This will run the validation checks and report the status to the PR.
|
||||
# Option 2 - Admin Bypass (for trusted bot PRs):
|
||||
# 1. Go to Actions > Validate Registry on PR > Run workflow
|
||||
# 2. Enter the PR number (e.g., 106)
|
||||
# 3. Check "skip_validation" checkbox
|
||||
# 4. Click "Run workflow"
|
||||
# 5. The check will pass immediately without running validation
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
|
|
@ -51,7 +58,8 @@ jobs:
|
|||
echo "" >> $GITHUB_STEP_SUMMARY
|
||||
echo "Validation checks skipped by maintainer." >> $GITHUB_STEP_SUMMARY
|
||||
echo "PR: #${{ github.event.inputs.pr_number }}" >> $GITHUB_STEP_SUMMARY
|
||||
exit 0
|
||||
echo "" >> $GITHUB_STEP_SUMMARY
|
||||
echo "The workflow will complete successfully without running validation steps." >> $GITHUB_STEP_SUMMARY
|
||||
|
||||
- name: Checkout repository (for manual runs)
|
||||
if: github.event_name == 'workflow_dispatch' && github.event.inputs.skip_validation != 'true'
|
||||
|
|
@ -82,6 +90,7 @@ jobs:
|
|||
token: ${{ secrets.GITHUB_TOKEN }}
|
||||
|
||||
- name: Detect fork PR
|
||||
if: github.event.inputs.skip_validation != 'true'
|
||||
id: fork_check
|
||||
run: |
|
||||
# For manual runs, use the fetched PR data
|
||||
|
|
@ -100,11 +109,13 @@ jobs:
|
|||
fi
|
||||
|
||||
- name: Install dependencies
|
||||
if: github.event.inputs.skip_validation != 'true'
|
||||
run: |
|
||||
sudo apt-get update
|
||||
sudo apt-get install -y jq
|
||||
|
||||
- name: Make scripts executable
|
||||
if: github.event.inputs.skip_validation != 'true'
|
||||
run: |
|
||||
chmod +x scripts/registry/validate-registry.sh
|
||||
chmod +x scripts/registry/auto-detect-components.sh
|
||||
|
|
@ -112,6 +123,7 @@ jobs:
|
|||
chmod +x scripts/prompts/validate-pr.sh
|
||||
|
||||
- name: Auto-detect new components
|
||||
if: github.event.inputs.skip_validation != 'true'
|
||||
id: auto_detect
|
||||
run: |
|
||||
echo "## 🔍 Auto-Detection Results" >> $GITHUB_STEP_SUMMARY
|
||||
|
|
@ -136,7 +148,7 @@ jobs:
|
|||
fi
|
||||
|
||||
- name: Add new components to registry
|
||||
if: steps.auto_detect.outputs.new_components == 'true'
|
||||
if: steps.auto_detect.outputs.new_components == 'true' && github.event.inputs.skip_validation != 'true'
|
||||
run: |
|
||||
echo "## 📝 Adding New Components" >> $GITHUB_STEP_SUMMARY
|
||||
echo "" >> $GITHUB_STEP_SUMMARY
|
||||
|
|
@ -144,6 +156,7 @@ jobs:
|
|||
./scripts/registry/auto-detect-components.sh --auto-add | tee -a $GITHUB_STEP_SUMMARY
|
||||
|
||||
- name: Validate prompt library structure
|
||||
if: github.event.inputs.skip_validation != 'true'
|
||||
id: validate_prompts
|
||||
run: |
|
||||
echo "## 🔍 Prompt Library Validation" >> $GITHUB_STEP_SUMMARY
|
||||
|
|
@ -175,6 +188,7 @@ jobs:
|
|||
fi
|
||||
|
||||
- name: Validate registry
|
||||
if: github.event.inputs.skip_validation != 'true'
|
||||
id: validate
|
||||
run: |
|
||||
echo "## ✅ Registry Validation" >> $GITHUB_STEP_SUMMARY
|
||||
|
|
@ -199,6 +213,7 @@ jobs:
|
|||
|
||||
- name: Commit registry updates (Internal PRs only)
|
||||
if: |
|
||||
github.event.inputs.skip_validation != 'true' &&
|
||||
steps.fork_check.outputs.is_fork == 'false' &&
|
||||
steps.auto_detect.outputs.new_components == 'true' &&
|
||||
steps.validate_prompts.outputs.prompt_validation == 'passed' &&
|
||||
|
|
@ -227,6 +242,7 @@ jobs:
|
|||
|
||||
- name: Fork PR notice
|
||||
if: |
|
||||
github.event.inputs.skip_validation != 'true' &&
|
||||
steps.fork_check.outputs.is_fork == 'true' &&
|
||||
steps.auto_detect.outputs.new_components == 'true' &&
|
||||
steps.validate_prompts.outputs.prompt_validation == 'passed' &&
|
||||
|
|
@ -256,7 +272,7 @@ jobs:
|
|||
});
|
||||
|
||||
- name: Fork PR summary
|
||||
if: steps.fork_check.outputs.is_fork == 'true'
|
||||
if: steps.fork_check.outputs.is_fork == 'true' && github.event.inputs.skip_validation != 'true'
|
||||
run: |
|
||||
echo "## 🔀 Fork PR Detected" >> $GITHUB_STEP_SUMMARY
|
||||
echo "" >> $GITHUB_STEP_SUMMARY
|
||||
|
|
|
|||
Loading…
Reference in a new issue