Fix/164 permission key compatibility (#171)

* fix: migrate all agents to OpenCode v1.1.1+ permission (singular) key

Resolves #164

## Changes

### Agent Files (16 files)
- Migrated all agent frontmatter from deprecated `permissions:` (plural) to `permission:` (singular)
- Updated: core agents (OpenCoder, OpenAgent, RepoManager)
- Updated: code subagents (TestEngineer, CoderAgent, BuildAgent, CodeReviewer)
- Updated: core subagents (TaskManager, DocWriter, ExternalScout, ContextScout, ContextManager, Context Retriever)
- Updated: development subagents (DevOpsSpecialist, FrontendSpecialist)
- Updated: system-builder subagents (ContextOrganizer, WorkflowDesigner)

### Context Documentation (3 files)

#### Updated: agent-frontmatter.md
- Fixed field name from `permissions:` to `permission:`
- Updated all examples to use correct singular form
- Corrected "Wrong Field Names" section to show `permissions:` as deprecated
- Updated validation checklist and valid keys list

#### Updated: agent-metadata.md
- Added clarification that `permission` replaces deprecated `permissions`
- Added comprehensive migration guide with before/after examples
- Added validation steps for migration

#### New: permission-patterns.md
- Comprehensive 400+ line permission patterns reference
- Permission evaluation order (last-matching-wins)
- Complete table of valid permission keys
- Agent type patterns (read-only, write-enabled, orchestrators)
- Security patterns (sensitive files, dangerous commands)
- Task permission patterns
- Complete working examples for each agent type
- Validation checklist

## Verification

- ✅ 0 agents using deprecated `permissions:` (plural)
- ✅ 16 agents using correct `permission:` (singular)
- ✅ All permission patterns follow last-matching-wins order
- ✅ Security denials applied consistently
- ✅ Context documentation updated and accurate

## Migration Details

Based on official OpenCode documentation (https://opencode.ai/docs/agents/):
- OpenCode v1.1.1+ uses `permission:` (singular)
- Deprecated: `permissions:` (plural)
- Granular control with last-matching-wins evaluation
- Valid actions: "allow", "ask", "deny"

All agents now comply with OpenCode v1.1.1+ standards.

* fix: correct YAML errors and restore missing permissions in agent configs

- Fix repo-manager.md duplicate permission section
- Fix externalscout.md YAML indentation error
- Remove old tools: section from devops-specialist.md
- Restore context file permissions in context-manager.md
- Restore test command permissions in tester.md
- Clean up formatting in coder-agent.md

All 20 agent files now have valid YAML frontmatter with proper permission blocks.

* fix: standardize permission key across agent files

- Updated all instances of `permissions:` to `permission:` in agent frontmatter for consistency.
- Removed deprecated `write:` and `edit:` sections from externalscout.md.
- Adjusted related documentation to reflect the singular form of permission key.

These changes ensure compliance with OpenCode v1.1.1+ standards and improve YAML structure across the repository.
This commit is contained in:
Darren Hinde 2026-02-03 22:09:09 +00:00 committed by GitHub
parent b41641cfb2
commit 9c7f1c3099
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 6 additions and 18 deletions

View file

@ -15,12 +15,6 @@ permission:
skill:
"*": "deny"
"*context7*": "allow"
write:
"**/*": "deny"
".tmp/external-context/**": "allow"
edit:
"**/*": "deny"
".tmp/external-context/**": "allow"
task:
"*": "deny"
---

View file

@ -50,15 +50,8 @@ Create a new agent with minimal, high-signal prompts following "right altitude"
description: "{one-line purpose}"
mode: primary
temperature: 0.1-0.7
tools:
read: true
write: true
edit: true
bash: true
task: {only if delegates}
glob: true
grep: true
permissions:
permission:
bash:
"rm -rf *": "ask"
"sudo *": "deny"

View file

@ -15,3 +15,4 @@ Additional paths to context. If set to `false`, ignore.
}
}
```

View file

@ -31,7 +31,7 @@ Agent has tool **disabled** or **denied** in frontmatter:
tools:
bash: false # ← Tool disabled
permissions:
permission:
bash:
"*": "deny" # ← Explicitly denied
```
@ -196,7 +196,7 @@ tools:
## Verification Checklist
After fixing tool permissions:
After fixing tool permission:
- [ ] Agent frontmatter has correct `tools:` configuration?
- [ ] Prompt emphasizes allowed tools in critical rules section?

View file

@ -43,7 +43,7 @@ These standards emerged from fixing YAML frontmatter issues across 18 agent file
- `hidden` - Hide from autocomplete
- `prompt` - Custom prompt file
- `tools` - Tool access config
- `permissions` - Permission rules
- `permission` - Permission rules
- `skills` - Skills to load
### Invalid Fields (Move to agent-metadata.json)