From 5c78f35c4b8c0c197881453a1682cf86eb0282e1 Mon Sep 17 00:00:00 2001 From: Darren Hinde <107584450+darrenhinde@users.noreply.github.com> Date: Tue, 9 Dec 2025 14:20:34 +0000 Subject: [PATCH] fix(ci): remove [skip ci] from version bump commits (#50) * fix(ci): remove [skip ci] from version bump commits to allow PR checks The [skip ci] flag was preventing PR checks from running on version bump PRs, making it impossible to validate them before merge. Changes: - Remove [skip ci] from version bump commit message - Update skip pattern to be more specific: '^chore: bump version to v' - Rely on 3-layer loop prevention: 1. Primary: PR label checking (version-bump, automated) 2. Secondary: Commit title pattern matching 3. Removed: [skip ci] flag (was blocking PR checks) This allows PR checks to run while still preventing infinite loops through label-based detection and commit title pattern matching. * chore: trigger CI checks --- .github/workflows/post-merge-pr.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/post-merge-pr.yml b/.github/workflows/post-merge-pr.yml index 6c7b0a5..cce3a7c 100644 --- a/.github/workflows/post-merge-pr.yml +++ b/.github/workflows/post-merge-pr.yml @@ -71,11 +71,11 @@ jobs: # Check commit title (first line only) for skip patterns COMMIT_TITLE=$(git log -1 --pretty=%s) - # Skip if this is an automated commit to prevent loops + # Skip if this is an automated version bump commit to prevent loops # Only check the title, not the full body to avoid false positives - if echo "$COMMIT_TITLE" | grep -qE "\[skip ci\]|chore: bump version"; then + if echo "$COMMIT_TITLE" | grep -qE "^chore: bump version to v"; then echo "should_bump=false" >> $GITHUB_OUTPUT - echo "Automated commit detected in title - skipping to prevent loops" + echo "Automated version bump commit detected - skipping to prevent loops" exit 0 fi @@ -164,7 +164,7 @@ jobs: NEW_VERSION="${{ steps.bump_version.outputs.new_version }}" git add VERSION package.json CHANGELOG.md - git commit -m "chore: bump version to v$NEW_VERSION [skip ci]" + git commit -m "chore: bump version to v$NEW_VERSION" - name: Push branch run: |