cclohmar/NextNVR
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: graceful stop via systemctl + targeted kill, no pkill -9

Browse source
This commit is contained in:
Claus Lohmar 2026-08-06 15:23:09 +01:00
parent 7b9902f788
commit a1f05012b4
2 changed files with 32 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
deploy_nvr.sh
View file

@ -39,18 +39,29 @@ if ! command -v sudo &>/dev/null; then
fi
fi
# ── 1. Kill all existing instances ──
# ── 1. Stop all existing instances ──
log "Stopping any running NextNVR instances..."
# Graceful stop via systemd first.
if systemctl is-active --quiet "${SERVICE_NAME}" 2>/dev/null; then
sudo systemctl stop "${SERVICE_NAME}" 2>/dev/null || true
sudo pkill -9 -f "/opt/nextnvr/nextnvr" 2>/dev/null || true
sudo pkill -9 -f "go2rtc -config" 2>/dev/null || true
sudo pkill -9 -f "ffmpeg.*-i rtsp" 2>/dev/null || true
sleep 2
fi
# Kill any remaining processes by PID (targeted, no wildcard pkill).
for proc in "/opt/nextnvr/nextnvr" "go2rtc"; do
for pid in $(pgrep -f "${proc}" 2>/dev/null || true); do
sudo kill "${pid}" 2>/dev/null || true
done
done
sleep 2
if pgrep -f "/opt/nextnvr/nextnvr" > /dev/null 2>&1; then
err "Cannot kill existing NextNVR processes. Please stop them manually and retry."
exit 1
fi
# Final check — force kill stragglers.
for pid in $(pgrep -f "/opt/nextnvr/nextnvr" 2>/dev/null || true); do
sudo kill -9 "${pid}" 2>/dev/null || true
done
sleep 1
log "All instances stopped."
# ── 2. Detect greenfield vs update ──

18
remove.sh
View file

@ -11,17 +11,21 @@ echo ""
# Stop service.
echo "Stopping service..."
if systemctl is-active --quiet "${SERVICE_NAME}" 2>/dev/null; then
sudo systemctl stop "${SERVICE_NAME}" 2>/dev/null || true
sudo systemctl disable "${SERVICE_NAME}" 2>/dev/null || true
sleep 2
fi
# Kill any lingering processes (target only NextNVR binaries, not the script).
echo "Killing processes..."
sudo pkill -9 -f "/opt/nextnvr/nextnvr" 2>/dev/null || true
sudo pkill -9 -f "go2rtc -config" 2>/dev/null || true
sudo pkill -9 -f "ffmpeg.*-i rtsp" 2>/dev/null || true
# Kill remaining processes by PID (targeted).
for proc in "/opt/nextnvr/nextnvr" "go2rtc"; do
for pid in $(pgrep -f "${proc}" 2>/dev/null || true); do
sudo kill "${pid}" 2>/dev/null || true
done
done
sleep 1
# Remove systemd service file.
# Remove systemd service.
sudo systemctl disable "${SERVICE_NAME}" 2>/dev/null || true
if [ -f "/etc/systemd/system/${SERVICE_NAME}.service" ]; then
sudo rm -f "/etc/systemd/system/${SERVICE_NAME}.service"
sudo systemctl daemon-reload